Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-3746: Adds reasons to trigger MRN failovers for testing #3280

Merged
merged 8 commits into from
Jan 15, 2025
Merged

EDU-3746: Adds reasons to trigger MRN failovers for testing #3280

merged 8 commits into from
Jan 15, 2025

Conversation

fairlydurable
Copy link
Contributor

Repurposing Blog material into Docs pages

@fairlydurable
EDU-3746: Adds reasons to trigger MRN failovers for testing
950c075 
Repurposing Blog material into Docs pages
@fairlydurable fairlydurable requested a review from a team as a code owner January 7, 2025 15:53
@fairlydurable
Copy link
Contributor Author

@meiliang86 Great feedback. Thank you. I'll get to work on improving it and incorporating links.

@fairlydurable
EDU-3744: respond to tech feedback
43cae25 
There will probably be additional feedback after these changes
@fairlydurable
Merge branch 'EDU-3746' of https://github.com/temporalio/documentation …
474acf1 
…into EDU-3746
@fairlydurable
Copy link
Contributor Author

fairlydurable commented Jan 9, 2025 •
edited
Loading

@atihkin @meiliang86

Many changes applied, including creating a table out of the two ways to manually fail over. Mention of the self-host checklist is completely removed. Links are added and all suggestions addressed. I also tried to add in appropriate introductions and motivations.

Outstanding questions for this ticket: (Answered on Slack)

- What is the exact audit log entry for failover? The current docs have "operation": FailoverNamespace" but that's missing at least one double quote or is possibly wrong. Thanks in advance.
- Is this still correct? "Whenever there is a failover event, users with the Account Owner and Global Admin roles automatically receive an alert email." Or is it that they receive alerts based on their currently-set preferences?

@fairlydurable
Copy link
Contributor Author

Direct link to change preview on Vercel

brianmacdonald-temporal
brianmacdonald-temporal approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; approved.

@fairlydurable fairlydurable merged commit 7c38cbb into main Jan 15, 2025
4 checks passed
@fairlydurable fairlydurable deleted the EDU-3746 branch January 15, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atihkin atihkin atihkin left review comments

@brianmacdonald-temporal brianmacdonald-temporal brianmacdonald-temporal approved these changes

@meiliang86 meiliang86 meiliang86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairlydurable @meiliang86 @atihkin @brianmacdonald-temporal