-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-3427: Project Nova: Worker pg break out including redirects and anchors #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsundai
changed the title
Worker pg break out redirects
Worker pg break out redirects and anchors
Jan 2, 2025
jsundai
changed the title
Worker pg break out redirects and anchors
Worker pg break out including redirects and anchors
Jan 2, 2025
jsundai
changed the title
Worker pg break out including redirects and anchors
Project Nova: Worker pg break out including redirects and anchors
Jan 2, 2025
Hi @jsundai! What's the status on this one? Thanks |
fairlydurable
changed the title
Project Nova: Worker pg break out including redirects and anchors
EDU-3427: Project Nova: Worker pg break out including redirects and anchors
Jan 10, 2025
brianmacdonald-temporal
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
changing long list of links into admonitions
adds TOC to each page
changing header levels to be higher levels for SEO
actual text has not been changed. just dividing up content to lessen cognitive load
Ready for review 🎉Please test out anchors and redirects using
yarn build
and preview usingyarn start
.Preview