Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide update to CONTRIBUTING.md #3266

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

jsundai
Copy link
Contributor

@jsundai jsundai commented Dec 30, 2024

assuming no prior knowledge

What does this PR do?

Notes to reviewers

assuming no prior knowledge
@jsundai
Copy link
Contributor Author

jsundai commented Jan 10, 2025

Ready for review - looking for ideas and feedback.

@fairlydurable
Copy link
Contributor

Hi @jsundai - Do you have a ticket number for this to help with tracking and reporting? Thanks!

@fairlydurable
Copy link
Contributor

fairlydurable commented Jan 10, 2025

Ready for review - looking for ideas and feedback.

Thank you for working on this. Great idea to modernize it!

I hope clarity on Clair's goals can help shape this page, motivating how we are open source, including docs, and how much we appreciate external contributions of all kinds and the benefits of leaving a mark on the community people are engaged with.

I also think it would help to talk about linking issues and PRs and what kinds of patches and enhancements people can offer.

Right now, there's no introduction and the instructions feel a little abrupt. I think that's easily fixed, and we can encourage further involvement with calls to action.

We should consider pushing Kapa as a great tool for checking whether material is already written but not yet in the docs themselves.

I look forward to seeing where this file ends up.

Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good revisions; well done.

@brianmacdonald-temporal brianmacdonald-temporal merged commit 70ca3fa into main Jan 10, 2025
3 checks passed
@brianmacdonald-temporal brianmacdonald-temporal deleted the update-contributors-guidance branch January 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants