Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad 'bp' value warning #2281

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix bad 'bp' value warning #2281

merged 1 commit into from
Nov 28, 2024

Commits on Nov 24, 2024

  1. Fix bad 'bp' value warning 

    We use `rbp` register in `mpi_mul_mont_mod_p256_x86_64`
function to save result of `mulxq` operation. That breaks
frame pointer convention and breaks stack traces. The same
problem described here:
https://lists.openwall.net/linux-kernel/2017/11/22/255
We can't use %rbp with CONFIG_FRAME_POINTER, so check
if CONFIG_FRAME_POINTER is set and use %rdi register
instead of %rbp.
    @EvgeniiMekhanik
    EvgeniiMekhanik committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    5b76bb3 View commit details
    Browse the repository at this point in the history