Do not remove idle streams immediatly. #2177
Open
+50
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/do-not-delete-idle-streams
branch
3 times, most recently
from
b20528d
to
f43442b
Compare
According to RFC 9113 section 5.1.1: The first use of a new stream identifier implicitly closes all streams in the "idle" state that might have been initiated by that peer with a lower-valued stream identifier. But Firefox creates idle streams and uses them as a nodes in priority tree and such streams should not be deleted. So we don't remove and delete idle streams if there count is less then TFW_MAX_IDLE_STREAMS (6). Also make two fixes: - add/remove idle streams under ctx lock. - add streams to idle queue in reverse order to avoid going through all list (new stream has usually greater stream id).
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/do-not-delete-idle-streams
branch
from
f43442b
to
4b513ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 9113 section 5.1.1:
The first use of a new stream identifier implicitly closes all streams in the "idle" state that might
have been initiated by that peer with a lower-valued stream identifier.
But Firefox creates idle streams and uses them as a nodes in priority tree and such streams should not be deleted. So we don't remove and delete idle streams if there count is less then TFW_MAX_IDLE_STREAMS (6). Also make two fixes: