-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify HTTP/1 req->host
and HTTP/2 :authority
processing
#1630
Comments
Current issue may contribute to #1667 |
Http2 pseudo-headers must be matched by HTTP Tables rules e.g Also we should to consider to rework our Host header parsing logic to satisfy this rule from RFC 7230 5.4:
|
If send h2 request with |
Please also fix https://github.com/tempesta-tech/tempesta/wiki/HTTP-tables
Which makes false statement about URI priority over Also please make Frang loaded by default to enforce default enabled |
Fixed in #1862 |
At the moment we store URI authority part in
req->host
for HTTP/1, but we have a designatedTFW_HTTP_HDR_H2_AUTHORITY
special header for HTTP/2 for:authority
. This complicates the logic (e.g. see #1629 (comment) discussion). Need to store URI authority for HTTP/1 in the special header, just as we do this for HTTP/2, and adjust all the places processingreq->host
.No need any special testing - these changes are well covered by the existing test suite.
The text was updated successfully, but these errors were encountered: