Forwarded HTTP header #1350 #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizhanovsky
requested changes
May 25, 2022
There was a problem hiding this comment.
@const-t thank you for your contribution! Quite a solid work, especially in the most complicated part, the parser.
May I ask you to make several improvements and simplifications along with the coding style cleanups? Some of the comments might need a discussion, especially the parser DSL macros.
Also I'd love to hear from you by e-mail ak @ tempesta-tech.com or a call https://calendly.com/tempesta-tech/60min : if you might be interested in job opportunities in our team or any other collaboration, then let's talk!
krizhanovsky
requested changes
Jun 25, 2022
krizhanovsky
approved these changes
Jul 3, 2022
const-t
force-pushed
the
ct-1350-forwarded-hdr
branch
3 times, most recently
from
082e551
to
18ee508
Compare
What has been implemented: - Parsing of "Forwarded" header. "for=" parameter parsed, but not used now. Only xff continues to be used. Also "Forwarded" not modified when forwarding to backend. - Choosing the right host by using keyword "host" in HTTPTables. - Highest priority has "URI", then "Host" and "Forwarded" - Added tests for validity of parsing and choosing host. - Added matching host of forwarded by http_host_required.
-http_limits: Removed garbage and simplified conditions -http_match: Removed line breaks -http_parser: Removed unnecessary line breaks. Fixed misaligned \ -http_parser: __(h2_)req_parse_forwarded() comments cleaned and added
__builtin_uaddl_overflow() in __parse_ulong() might write larger than 2 bytes to port before "if" checks the limit. At the moment, thank to data alignment, we have extra 2 bytes in the union, but this might change and we'll get a vulnerability.
-Edited large comment about __msg_field_open and explicit fixup. -Added macroses to __(h2)_req_parse_forwarded that allows to use __msg_field_open in forwarded parsing. Manual manipulation with "p" pointer replaced by these macroses.
const-t
force-pushed
the
ct-1350-forwarded-hdr
branch
from
18ee508
to
b9ffb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been implemented:
not used now. Only xff continues to be used. Also "Forwarded"
not modified when forwarding to backend.