disable failing h2spec tests
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the latest changes, I've ran for 10 times in a row and I got this:
|
|
FYI: for some reason: that function was not even used anywhere. |
5 tasks
|
Both of the warnings are known Tempesta FW issues, I added comment tempesta-tech/tempesta#1387 (comment) I think we can delete |
krizhanovsky
approved these changes
Jul 26, 2022
| @@ -81,22 +81,23 @@ def copy_files(self): | |||
| for (name, content) in self.files: | |||
There was a problem hiding this comment.
Could you please add the copyright headers to the file:
__author__ = 'Tempesta Technologies, Inc.'
__copyright__ = 'Copyright (C) 2018-2022 Tempesta Technologies, Inc.'
__license__ = 'GPL2'
h2/test_h2_specs.py
Outdated
| @@ -74,7 +74,7 @@ class H2Spec(tester.TempestaTest): | |||
| 'type' : 'external', | |||
There was a problem hiding this comment.
Please update the copyright year in the file and other files, which you ever touch.
nickzaev
changed the title
h2spec testsh2spec tests
|
With our latest changes to |
pale-emperor
approved these changes
Aug 3, 2022
s0nx
reviewed
Aug 3, 2022
| @@ -154,5 +155,7 @@ def set_user_agent(self, ua): | |||
| self.options.append('-H \'User-Agent: %s\'' % ua) | |||
|
|
|||
| def wait_for_finish(self): | |||
| self.proc.join() | |||
| # until we explicitly get `self.exit_event` flag set | |||
| while self.is_busy(verbose=False): | |||
There was a problem hiding this comment.
Can't we use self.exit_event.wait(some timeout) here?
There was a problem hiding this comment.
Internally it uses locks and does some extra job, but we're not setting that event flag in different places, hence we don't really need it.
s0nx
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
--excludeflag in ourh2specfork, we can gracefullydisable some failing
h2spectests.