#26 filter: Fixed bug and heavy refactoring. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit did not actually 'fix' the bug. My assumptions on how 'preg_replace_callback' worked were wrong. The refactoring was nice though, so I am keeping it.
The bug was an issue with having some hyperlinks inside other hyperlinks, which didn't work well with the regex in charge to add the iframes. I added a function to fix that first (adding <a> and </a> ala browser parser) and THEN do the usual replacing.
Conflicts: Resources/data/pumoodle/filter/pumukit/filter.php The conflict was caused by 00b9b18, task #11857 Changed iframe width/height according to commit.
|
@rubenrua Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was difficult to handle, so I had to refactor it in order to fix the bug properly.