Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Connection Limit Invalid for Queue/Topic Limits Greater than 100 #73

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

Lukejkw
Copy link
Contributor

@Lukejkw Lukejkw commented Jan 27, 2023

Fixes Issue #63

Queues and topic helpers now use paginated approach for querying.

Chore:

  • Removed unused interface method
  • Reused ManagementClient for populating topic subscriptions for more efficient use of connections

Notes:

I didn't want to make wide sweeping changes and just focused on fixing the reported issue.

Ideally, I'd like to split up the helper classes into SRP services and create a generic batching function for querying paginated methods like the get topic and queue methods.

@armannaj
Copy link
Contributor

Thanks for your contribution @Lukejkw .. I'm having a look at the proposed changes.

Re: proposed refactoring, the ideal plan is we clear up some/most of the reported issues first and then focus on the refactoring and new features. That'd be awesome

@armannaj armannaj merged commit e254568 into telstrapurple:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants