Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Fix #285 - Cycle payment should never exceed cycle payment amt #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Audit Fix #285 - Cycle payment should never exceed cycle payment amt #42

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe9c9b
add
ethereumdegen May 15, 2024
8ac0e10
remove interst dbl count
ethereumdegen Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions packages/contracts/contracts/libraries/V2Calculations.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,18 @@ library V2Calculations {
_bid.loanDetails.principal -
_bid.loanDetails.totalRepaid.principal;

uint256 daysInYear = _paymentCycleType == PaymentCycleType.Monthly
uint256 owedTime = _timestamp - uint256(_lastRepaidTimestamp);

{
uint256 daysInYear = _paymentCycleType == PaymentCycleType.Monthly
? 360 days
: 365 days;

uint256 interestOwedInAYear = owedPrincipal_.percent(_bid.terms.APR);
uint256 owedTime = _timestamp - uint256(_lastRepaidTimestamp);
interest_ = (interestOwedInAYear * owedTime) / daysInYear;
uint256 interestOwedInAYear = owedPrincipal_.percent(_bid.terms.APR);

interest_ = (interestOwedInAYear * owedTime) / daysInYear;
}


bool isLastPaymentCycle;
{
Expand Down Expand Up @@ -121,10 +126,13 @@ library V2Calculations {
// Max payable amount in a cycle
// NOTE: the last cycle could have less than the calculated payment amount

//the amount owed for the cycle should never exceed the current payment cycle amount so we use min here
uint256 owedAmountForCycle = Math.min( ((_bid.terms.paymentCycleAmount * owedTime)+interest_ ) /
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we just got rid of the left hand side of this Math.min ???

_paymentCycleDuration , _bid.terms.paymentCycleAmount+interest_ ) ;

uint256 owedAmount = isLastPaymentCycle
? owedPrincipal_ + interest_
: (_bid.terms.paymentCycleAmount * owedTime) /
_paymentCycleDuration;
: owedAmountForCycle ;

duePrincipal_ = Math.min(owedAmount - interest_, owedPrincipal_);
}
Expand Down
Loading