-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html specs corrections 6 #5230
Merged
Merged
Html specs corrections 6 #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeyaVes
force-pushed
the
html-specs-corrections-6
branch
3 times, most recently
from
November 14, 2024 12:09
82d18d9
to
d6b54ce
Compare
TeyaVes
requested review from
kendo-bot and
a team
and removed request for
a team and
kendo-bot
November 14, 2024 12:30
epetrow
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks OK :) Just one suggestion from me - simplify Gantt templates - should be chore commit; |
inikolova
approved these changes
Nov 18, 2024
TeyaVes
force-pushed
the
html-specs-corrections-6
branch
from
November 19, 2024 14:42
300196f
to
39b6368
Compare
I've updated the commit message to chore() instead of fix() |
TeyaVes
force-pushed
the
html-specs-corrections-6
branch
from
November 20, 2024 07:53
30134c1
to
ce1df77
Compare
zhpenkov
reviewed
Nov 20, 2024
packages/html/src/pivotgrid/templates/pivotgrid-with-configurator-opened.tsx
Outdated
Show resolved
Hide resolved
TeyaVes
force-pushed
the
html-specs-corrections-6
branch
2 times, most recently
from
November 20, 2024 15:20
9b245bd
to
f721dc5
Compare
TeyaVes
force-pushed
the
html-specs-corrections-6
branch
from
November 22, 2024 13:21
fbf29db
to
83c9c21
Compare
The touch-action none is now enforced through the themes rather than with a utility class
TeyaVes
force-pushed
the
html-specs-corrections-6
branch
from
November 22, 2024 13:25
83c9c21
to
7ffdead
Compare
zhpenkov
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets: https://github.com/telerik/kendo-themes-private/issues/246
This PR targets the following items from the related issue:
Splitter
the touch-action: none style is added to the themes and the utility class is no longer needed. It needs to be removed from the specs.
Gantt
PivotGrid/Checkbox
I think that we should leave this wrapper with the class- in this way we can target the text inside the cell, without affecting the toggle icon which might be present. Similarly, we have a wrapper for the text inside pivotGrid headers- .k-pivotgrid-header-title
Inputs
The purpose of the templates are to give guidelines for the static reference rendering of the componets. Adding states to inputs under certain conditions should not be in the scope of the specs. Thus, the inputs when a dropdown is opened will currently remain unchanged.
AI Prompt
I think that we should not add such a class as a part of the rendering or a style in the component, as it imposes certain styles to the card body content and we do not want that- the client should be responsible for that