Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grid): define variables for large grid #4500

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat(grid): define variables for large grid #4500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
702f529
feat(grid): define variables for large grid
epetrow May 23, 2023
6012d55
test(grid): add large size test
epetrow May 26, 2023
732bb4a
chore: update visual previews
kendo-bot May 26, 2023
1f953cf
Merge branch 'develop' into grid-lg
epetrow May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bootstrap/scss/chip/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ $kendo-chip-lg-line-height: $kendo-chip-line-height !default;
/// @group chip
$kendo-chip-calc-size: calc( #{$kendo-chip-line-height * 1em} + #{$kendo-chip-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;
$kendo-chip-sm-calc-size: calc( #{$kendo-chip-sm-line-height * 1em} + #{$kendo-chip-sm-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;

$kendo-chip-lg-calc-size: calc( #{$kendo-chip-lg-line-height * 1em} + #{$kendo-chip-lg-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;

/// The map with the sizes of the Chip.
/// @group chip
Expand Down
32 changes: 32 additions & 0 deletions packages/bootstrap/scss/grid/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,21 @@ $kendo-grid-md-group-dropclue-height: $kendo-grid-group-drop-hint-height !defaul
$kendo-grid-md-selection-aggregates-padding-x: $kendo-grid-padding-y !default;
$kendo-grid-md-selection-aggregates-padding-y: $kendo-grid-padding-y !default;

$kendo-grid-lg-padding-x: $kendo-table-lg-cell-padding-x !default;
$kendo-grid-lg-padding-y: $kendo-table-lg-cell-padding-y !default;
$kendo-grid-lg-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-grouping-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-grouping-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-cell-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-cell-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-x: $kendo-grid-lg-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-y: 6px !default;
$kendo-grid-lg-group-dropclue-height: calc( #{$kendo-chip-lg-calc-size} + #{$kendo-grid-group-drop-hint-size}) !default;
$kendo-grid-lg-selection-aggregates-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-selection-aggregates-padding-y: $kendo-grid-lg-padding-y !default;

// Kendo Grid sizes
$kendo-grid-sizes: (
Expand Down Expand Up @@ -121,6 +136,23 @@ $kendo-grid-sizes: (
selection-aggregates-padding-x: $kendo-grid-md-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-md-selection-aggregates-padding-y
),
lg: (
header-padding-x: $kendo-grid-lg-header-padding-x,
header-padding-y: $kendo-grid-lg-header-padding-y,
grouping-header-padding-x: $kendo-grid-lg-grouping-header-padding-x,
grouping-header-padding-y: $kendo-grid-lg-grouping-header-padding-y,
cell-padding-x: $kendo-grid-lg-cell-padding-x,
cell-padding-y: $kendo-grid-lg-cell-padding-y,
filter-cell-padding-x: $kendo-grid-lg-filter-cell-padding-x,
filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-y,
edit-cell-padding-x: $kendo-grid-lg-edit-cell-padding-x,
edit-cell-padding-y: $kendo-grid-lg-edit-cell-padding-y,
button-padding-y: $kendo-button-lg-padding-y,
button-calc-size: $kendo-button-lg-calc-size,
group-dropclue-height: $kendo-grid-lg-group-dropclue-height,
selection-aggregates-padding-x: $kendo-grid-lg-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-lg-selection-aggregates-padding-y,
)
) !default;

$kendo-grid-header-font-size: null !default;
Expand Down
1 change: 1 addition & 0 deletions packages/classic/scss/chip/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ $kendo-chip-lg-line-height: $kendo-chip-line-height !default;
/// @group chip
$kendo-chip-calc-size: calc( #{$kendo-chip-line-height * 1em} + #{$kendo-chip-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;
$kendo-chip-sm-calc-size: calc( #{$kendo-chip-sm-line-height * 1em} + #{$kendo-chip-sm-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;
$kendo-chip-lg-calc-size: calc( #{$kendo-chip-lg-line-height * 1em} + #{$kendo-chip-lg-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;

/// The map with the sizes of the Chip.
/// @group chip
Expand Down
32 changes: 32 additions & 0 deletions packages/classic/scss/grid/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,21 @@ $kendo-grid-md-group-dropclue-height: $kendo-grid-group-drop-hint-height !defaul
$kendo-grid-md-selection-aggregates-padding-x: $kendo-grid-padding-y !default;
$kendo-grid-md-selection-aggregates-padding-y: $kendo-grid-padding-y !default;

$kendo-grid-lg-padding-x: $kendo-table-lg-cell-padding-x !default;
$kendo-grid-lg-padding-y: $kendo-table-lg-cell-padding-y !default;
$kendo-grid-lg-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-grouping-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-grouping-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-cell-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-cell-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-x: $kendo-grid-lg-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-y: 6px !default;
$kendo-grid-lg-group-dropclue-height: calc( #{$kendo-chip-lg-calc-size} + #{$kendo-grid-group-drop-hint-size}) !default;
$kendo-grid-lg-selection-aggregates-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-selection-aggregates-padding-y: $kendo-grid-lg-padding-y !default;

// Kendo Grid sizes
$kendo-grid-sizes: (
Expand Down Expand Up @@ -127,6 +142,23 @@ $kendo-grid-sizes: (
selection-aggregates-padding-x: $kendo-grid-md-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-md-selection-aggregates-padding-y
),
lg: (
header-padding-x: $kendo-grid-lg-header-padding-x,
header-padding-y: $kendo-grid-lg-header-padding-y,
grouping-header-padding-x: $kendo-grid-lg-grouping-header-padding-x,
grouping-header-padding-y: $kendo-grid-lg-grouping-header-padding-y,
cell-padding-x: $kendo-grid-lg-cell-padding-x,
cell-padding-y: $kendo-grid-lg-cell-padding-y,
filter-cell-padding-x: $kendo-grid-lg-filter-cell-padding-x,
filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-y,
edit-cell-padding-x: $kendo-grid-lg-edit-cell-padding-x,
edit-cell-padding-y: $kendo-grid-lg-edit-cell-padding-y,
button-padding-y: $kendo-button-lg-padding-y,
button-calc-size: $kendo-button-lg-calc-size,
group-dropclue-height: $kendo-grid-lg-group-dropclue-height,
selection-aggregates-padding-x: $kendo-grid-lg-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-lg-selection-aggregates-padding-y,
)
) !default;


Expand Down
1 change: 1 addition & 0 deletions packages/default/scss/chip/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ $kendo-chip-lg-line-height: $kendo-chip-line-height !default;
/// @group chip
$kendo-chip-calc-size: calc( #{$kendo-chip-line-height * 1em} + #{$kendo-chip-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;
$kendo-chip-sm-calc-size: calc( #{$kendo-chip-sm-line-height * 1em} + #{$kendo-chip-sm-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;
$kendo-chip-lg-calc-size: calc( #{$kendo-chip-lg-line-height * 1em} + #{$kendo-chip-lg-padding-y * 2} + #{$kendo-chip-border-width * 2} ) !default;

/// The map with the sizes of the Chip.
/// @group chip
Expand Down
32 changes: 32 additions & 0 deletions packages/default/scss/grid/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,21 @@ $kendo-grid-md-group-dropclue-height: $kendo-grid-group-drop-hint-height !defaul
$kendo-grid-md-selection-aggregates-padding-x: $kendo-grid-padding-y !default;
$kendo-grid-md-selection-aggregates-padding-y: $kendo-grid-padding-y !default;

$kendo-grid-lg-padding-x: $kendo-table-lg-cell-padding-x !default;
$kendo-grid-lg-padding-y: $kendo-table-lg-cell-padding-y !default;
$kendo-grid-lg-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-grouping-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-grouping-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-cell-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-cell-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-x: $kendo-grid-lg-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-y: 6px !default;
$kendo-grid-lg-group-dropclue-height: calc( #{$kendo-chip-lg-calc-size} + #{$kendo-grid-group-drop-hint-size}) !default;
$kendo-grid-lg-selection-aggregates-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-selection-aggregates-padding-y: $kendo-grid-lg-padding-y !default;

// Kendo Grid sizes
$kendo-grid-sizes: (
Expand Down Expand Up @@ -120,6 +135,23 @@ $kendo-grid-sizes: (
selection-aggregates-padding-x: $kendo-grid-md-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-md-selection-aggregates-padding-y
),
lg: (
header-padding-x: $kendo-grid-lg-header-padding-x,
header-padding-y: $kendo-grid-lg-header-padding-y,
grouping-header-padding-x: $kendo-grid-lg-grouping-header-padding-x,
grouping-header-padding-y: $kendo-grid-lg-grouping-header-padding-y,
cell-padding-x: $kendo-grid-lg-cell-padding-x,
cell-padding-y: $kendo-grid-lg-cell-padding-y,
filter-cell-padding-x: $kendo-grid-lg-filter-cell-padding-x,
filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-y,
edit-cell-padding-x: $kendo-grid-lg-edit-cell-padding-x,
edit-cell-padding-y: $kendo-grid-lg-edit-cell-padding-y,
button-padding-y: $kendo-button-lg-padding-y,
button-calc-size: $kendo-button-lg-calc-size,
group-dropclue-height: $kendo-grid-lg-group-dropclue-height,
selection-aggregates-padding-x: $kendo-grid-lg-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-lg-selection-aggregates-padding-y,
)
) !default;

$kendo-grid-header-font-size: null !default;
Expand Down
1 change: 1 addition & 0 deletions packages/fluent/scss/chip/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ $kendo-chip-lg-line-height: var( --kendo-line-height, normal ) !default;
/// @group chip
$kendo-chip-calc-size: calc( #{$kendo-chip-md-line-height} * 1em + #{$kendo-chip-md-padding-y} * 2 + #{$kendo-chip-border-width} * 2 ) !default;
$kendo-chip-sm-calc-size: calc( #{$kendo-chip-sm-line-height} * 1em + #{$kendo-chip-sm-padding-y} * 2 + #{$kendo-chip-border-width} * 2 ) !default;
$kendo-chip-lg-calc-size: calc( #{$kendo-chip-lg-line-height} * 1em + #{$kendo-chip-lg-padding-y} * 2 + #{$kendo-chip-border-width} * 2 ) !default;

/// The map with the sizes of the Chip.
/// @group chip
Expand Down
32 changes: 32 additions & 0 deletions packages/fluent/scss/grid/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,21 @@ $kendo-grid-md-group-dropclue-height: $kendo-grid-group-drop-hint-height !defaul
$kendo-grid-md-selection-aggregates-padding-x: map.get( $kendo-spacing, 2 ) !default;
$kendo-grid-md-selection-aggregates-padding-y: $kendo-grid-md-selection-aggregates-padding-x !default;

$kendo-grid-lg-padding-x: $kendo-table-lg-cell-padding-x !default;
$kendo-grid-lg-padding-y: $kendo-table-lg-cell-padding-y !default;
$kendo-grid-lg-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-grouping-header-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-grouping-header-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-cell-padding-x: $kendo-grid-lg-padding-x !default;
$kendo-grid-lg-cell-padding-y: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-x: $kendo-grid-lg-cell-padding-x !default;
$kendo-grid-lg-edit-cell-padding-y: 6px !default;
$kendo-grid-lg-group-dropclue-height: calc( #{$kendo-chip-lg-calc-size} + #{$kendo-grid-group-drop-hint-size}) !default;
$kendo-grid-lg-selection-aggregates-padding-x: $kendo-grid-lg-padding-y !default;
$kendo-grid-lg-selection-aggregates-padding-y: $kendo-grid-lg-padding-y !default;

// Kendo Grid sizes
$kendo-grid-sizes: (
Expand Down Expand Up @@ -151,6 +166,23 @@ $kendo-grid-sizes: (
selection-aggregates-padding-x: $kendo-grid-md-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-md-selection-aggregates-padding-y
),
lg: (
header-padding-x: $kendo-grid-lg-header-padding-x,
header-padding-y: $kendo-grid-lg-header-padding-y,
grouping-header-padding-x: $kendo-grid-lg-grouping-header-padding-x,
grouping-header-padding-y: $kendo-grid-lg-grouping-header-padding-y,
cell-padding-x: $kendo-grid-lg-cell-padding-x,
cell-padding-y: $kendo-grid-lg-cell-padding-y,
filter-cell-padding-x: $kendo-grid-lg-filter-cell-padding-x,
filter-cell-padding-y: $kendo-grid-lg-filter-cell-padding-y,
edit-cell-padding-x: $kendo-grid-lg-edit-cell-padding-x,
edit-cell-padding-y: $kendo-grid-lg-edit-cell-padding-y,
button-padding-y: $kendo-button-lg-padding-y,
button-calc-size: $kendo-button-lg-calc-size,
group-dropclue-height: $kendo-grid-lg-group-dropclue-height,
selection-aggregates-padding-x: $kendo-grid-lg-selection-aggregates-padding-x,
selection-aggregates-padding-y: $kendo-grid-lg-selection-aggregates-padding-y,
)
) !default;


Expand Down
Loading