-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite ecommerce sample app #2687
Conversation
examples/ecommerce-jewellery-store/src/components/CardsList.tsx
Outdated
Show resolved
Hide resolved
examples/ecommerce-jewellery-store/src/components/CategoryList.tsx
Outdated
Show resolved
Hide resolved
examples/ecommerce-jewellery-store/src/components/ShoppingCartList.tsx
Outdated
Show resolved
Hide resolved
return ( | ||
<div | ||
className="k-d-flex k-gap-5 k-justify-content-center k-border-y k-align-items-center k-pb-5" | ||
key={isCartItem ? item.product.id : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in children having duplicated unique keys and this is bad because components with same keys may cause children to be duplicated and/or omitted. Please reconsider using the index of each child as unique key -> something like: cart-item-${index}
Make sure the following commands pass.
|
The |
update README with available commands
Related to https://github.com/telerik/kendo-react-private/issues/4360
The PR is opened so that we can deploy what we have so far. Polishing of the UI will be added in the next two days. The following discrepancies with the design can be expected: