Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: promote stepAction to beta #7920

Merged
merged 1 commit into from
May 15, 2024
Merged

misc: promote stepAction to beta #7920

merged 1 commit into from
May 15, 2024

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Apr 26, 2024 •
edited by chitrangpatel
Loading

Promote StepAction to Beta.

This PR promotes StepActions to beta. It adds the necessary types and configs and conversion webhooks. It also updates the internal storage type to use v1beta1 for StepActions.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

promote StepActions to beta

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. labels Apr 26, 2024
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 26, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/stepaction_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/result_validation.go 100.0% 80.8% -19.2
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 92.3%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 98.9% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.4% -5.8
test/parse/yaml.go 50.6% 13.1% -37.5
test/parse/yaml.go Do not exist 10.7%
test/parse/yaml.go Do not exist 50.6%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/stepaction_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/result_validation.go 100.0% 80.8% -19.2
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 92.3%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 98.9% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.4% -5.8
test/parse/yaml.go 50.6% 33.7% -16.9
test/parse/yaml.go Do not exist 17.5%
test/parse/yaml.go Do not exist 8.3%

@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch from df7352a to f612352 Compare April 27, 2024 02:30
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/stepaction_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/result_validation.go 100.0% 80.8% -19.2
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 92.3%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 98.9% 0.3
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.4% -5.8
test/parse/yaml.go 50.6% 19.6% -31.0
test/parse/yaml.go Do not exist 15.1%
test/parse/yaml.go Do not exist 38.7%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/stepaction_conversion.go Do not exist 66.7%
pkg/apis/pipeline/v1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/result_validation.go 100.0% 80.8% -19.2
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 92.3%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 98.9% 0.3
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.4% -5.8
test/parse/yaml.go 50.6% 33.7% -16.9
test/parse/yaml.go Do not exist 17.5%
test/parse/yaml.go Do not exist 8.3%

chitrangpatel
chitrangpatel requested changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick early comment.

We should not be adding StepAction types in V1. Only add it to v1beta1.
We need to still keep them in v1alpha1 as well otherwise we would be deprecate it immediately which is breaking for the users. For now, we will have it in v1alpha1 and v1beta1 and have conversion between them. Nothing in v1.

We will add it to v1 when we make StepActions stable. At that point, we will remove v1alpha1 and leave v1beta1 and v1. And 9 months after we send out a deprecation notice for v1beta1, we can remove the types from v1beta1.

Happy to discuss more.

@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch from f612352 to 5c4cd78 Compare April 27, 2024 17:14
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 17.5% -33.2
test/parse/yaml.go Do not exist 13.1%
test/parse/yaml.go Do not exist 38.7%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 33.7% -16.9
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 8.3%

@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch 2 times, most recently from 32f5a43 to 33dd911 Compare April 27, 2024 18:25
@ericzzzzzzz ericzzzzzzz changed the title chore: promote stepAction to beta misc: promote stepAction to beta Apr 27, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 13.1% -37.5
test/parse/yaml.go Do not exist 8.3%
test/parse/yaml.go Do not exist 47.6%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 33.7% -16.9
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 8.3%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 33.7% -16.9
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 8.3%

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Apr 28, 2024
@ericzzzzzzz
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2024
@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch from 33dd911 to fed03dc Compare April 29, 2024 14:31
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 17.5% -33.2
test/parse/yaml.go Do not exist 13.1%
test/parse/yaml.go Do not exist 38.7%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 88.3% -5.9
test/parse/yaml.go 50.6% 69.0% 18.4
test/parse/yaml.go Do not exist 19.0%
test/parse/yaml.go Do not exist 14.9%
test/parse/yaml.go Do not exist 8.3%

chitrangpatel
chitrangpatel approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments regarding coverage. Otherwise all good!

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch from fed03dc to 6bb6a73 Compare April 29, 2024 15:15
@chitrangpatel chitrangpatel added this to the Pipeline v0.60 milestone Apr 29, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.0% -1.2
test/parse/yaml.go 50.6% 17.5% -33.2
test/parse/yaml.go Do not exist 13.1%
test/parse/yaml.go Do not exist 38.7%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.0% -1.2
test/parse/yaml.go 50.6% 33.7% -16.9
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 8.3%

@chitrangpatel
Copy link
Contributor

@tektoncd/core-collaborators PTAL.
Looking for a review from a non-Googler. Thanks!

@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch from 6bb6a73 to 10bc79c Compare May 10, 2024 13:14
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.0% -1.2
test/parse/yaml.go 8.9% 19.0% 10.2
test/parse/yaml.go Do not exist 25.7%
test/parse/yaml.go Do not exist 8.3%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 88.9% 88.9
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.0% -1.2
test/parse/yaml.go 8.9% 33.7% 24.9
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 8.3%

@chitrangpatel chitrangpatel requested a review from JeromeJu May 10, 2024 15:22
@ericzzzzzzz ericzzzzzzz force-pushed the promote-step-action-to-beta branch from 10bc79c to c60148d Compare May 13, 2024 14:55
JeromeJu
JeromeJu approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@JeromeJu JeromeJu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM - also learned offline from Chitrang that the trusted StepAction will be something we pursue post-Beta or GA.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,chitrangpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 94.4% 94.4
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.0% -1.2
test/parse/yaml.go 8.9% 19.0% 10.2
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 30.2%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go 0.0% 94.4% 94.4
pkg/apis/pipeline/v1beta1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_defaults.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1beta1/stepaction_validation.go Do not exist 98.9%
pkg/reconciler/apiserver/apiserver.go 97.2% 97.6% 0.3
pkg/reconciler/taskrun/resources/taskref.go 94.2% 93.0% -1.2
test/parse/yaml.go 8.9% 33.7% 24.9
test/parse/yaml.go Do not exist 15.5%
test/parse/yaml.go Do not exist 8.3%

@JeromeJu
Copy link
Member

WG @tektoncd/core-maintainers PTAL for the v0.60 milestone

@chitrangpatel
Copy link
Contributor

Merging this now since everyone has been on board with promoting stepactions to beta.
This just adds the same structs into v1beta1, updates the storage type and adds conversion logic between v1alpha1 and v1beta1 as per the TEP. Its not doing anything that may be controversial.
It has been open for three weeks already so I'm merging this in using maintainer discretion and because of reasons mentioned above.

Happy to resolve any friction/comments in a follow-up PR if needed.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@tekton-robot tekton-robot merged commit 2bd16b8 into tektoncd:main May 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@JeromeJu JeromeJu JeromeJu approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jerop jerop Awaiting requested review from jerop

Assignees

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Pipeline v0.60
Development

Successfully merging this pull request may close these issues.
4 participants
@ericzzzzzzz @tekton-robot @chitrangpatel @JeromeJu