Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: make codeql a bit quicker #7728

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 29, 2024

Changes

  • Use actions/cache to be able to use golang cache (uses **/go.sum to compute the cache hash). This should speed up compilation for any pull-requests that doesn't update dependencies.
  • Do not rely on autobuild, but use make binaries to build all binaries.

/cc @afrittoli @chitrangpatel @JeromeJu
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 29, 2024
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 29, 2024
@vdemeester
Copy link
Member Author

Ah it… fails because, I am adding the binaries target in the same pull-request.. 😅. I could change the Makefile (or the command) in another 🤔

@afrittoli
Copy link
Member

Ah it… fails because, I am adding the binaries target in the same pull-request.. 😅. I could change the Makefile (or the command) in another 🤔

Uhm, shouldn't it use the code from the PR?

@vdemeester
Copy link
Member Author

Ah it… fails because, I am adding the binaries target in the same pull-request.. 😅. I could change the Makefile (or the command) in another 🤔

Uhm, shouldn't it use the code from the PR?

Nope, that’s one limitation of GitHub actions and forks. It would run the code from the PR if it is coming from the same repository, but not from a fork. That’s.. a bit of a pain 😅

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2024
@JeromeJu JeromeJu self-assigned this Mar 5, 2024
@vdemeester vdemeester force-pushed the make-codeql-quicker branch from 3510770 to ff0a331 Compare March 20, 2024 04:25
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@vdemeester vdemeester force-pushed the make-codeql-quicker branch from ff0a331 to 0b98aa4 Compare March 20, 2024 04:52
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
- Use `actions/cache` to be able to use golang cache (uses `**/go.sum`
 to compute the cache hash). This should speed up compilation for any
 pull-requests that doesn't update dependencies.
- Do not rely on autobuild, but use `make bin/*` to build all binaries
 (and add a `make binaries` for the future).

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the make-codeql-quicker branch from 0b98aa4 to 507a9fd Compare March 28, 2024 12:19
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@vdemeester
Copy link
Member Author

cc @JeromeJu @chitrangpatel

@chitrangpatel
Copy link
Contributor

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@JeromeJu
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit c2ab0b3 into tektoncd:main Mar 28, 2024
13 checks passed
@vdemeester vdemeester deleted the make-codeql-quicker branch March 28, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants