-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: make codeql a bit quicker #7728
Conversation
Ah it… fails because, I am adding the binaries target in the same pull-request.. 😅. I could change the |
Uhm, shouldn't it use the code from the PR? |
Nope, that’s one limitation of GitHub actions and forks. It would run the code from the PR if it is coming from the same repository, but not from a fork. That’s.. a bit of a pain 😅 |
3510770
to
ff0a331
Compare
ff0a331
to
0b98aa4
Compare
- Use `actions/cache` to be able to use golang cache (uses `**/go.sum` to compute the cache hash). This should speed up compilation for any pull-requests that doesn't update dependencies. - Do not rely on autobuild, but use `make bin/*` to build all binaries (and add a `make binaries` for the future). Signed-off-by: Vincent Demeester <[email protected]>
0b98aa4
to
507a9fd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Changes
actions/cache
to be able to use golang cache (uses**/go.sum
to compute the cache hash). This should speed up compilation for any pull-requests that doesn't update dependencies.make binaries
to build all binaries./cc @afrittoli @chitrangpatel @JeromeJu
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes