Exclude stopped injected sidecars from TaskRun status #7642
Conversation
fixes tektoncd#7640 In tektoncd#5565, we started stopping injected sidecars with `nop` in the same way we stop explicitly defined sidecar containers. `MakeTaskRunStatus` was updated to only include explicitly defined sidecars in the `TaskRun` status, rather than just any container in the `TaskRun` pod that doesn't start with `step-`, so while the pod is running, the injected sidecar doesn't show up in the status. However, once the pod has completed and the sidecars are stopped, if the `TaskRun`'s spec contains a sidecar, `updateStoppedSidecarStatus` will be called, and that function's logic for what containers to include in `TaskRun.Status.Sidecars` is still including everything but `step-`-prefixed containers. That should be updated to behave in the same way as `MakeTaskRunStatus`. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
added
kind/bug
tekton-robot
added
the
size/M
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
approved
|
I don't know if this needs to be backported to LTSes - it doesn't feel like a critical problem to me, it just happened to break tooling I was working on. =) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v0.56.x |
|
@vdemeester: new pull request created: #7653 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v0.53.x |
Changes
fixes #7640
In #5565, we started stopping injected sidecars with
nopin the same way we stop explicitly defined sidecar containers.MakeTaskRunStatuswas updated to only include explicitly defined sidecars in theTaskRunstatus, rather than just any container in theTaskRunpod that doesn't start withstep-, so while the pod is running, the injected sidecar doesn't show up in the status. However, once the pod has completed and the sidecars are stopped, if theTaskRun's spec contains a sidecar,updateStoppedSidecarStatuswill be called, and that function's logic for what containers to include inTaskRun.Status.Sidecarsis still including everything butstep--prefixed containers. That should be updated to behave in the same way asMakeTaskRunStatus./kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes