-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docker-in-docker testimage for s390x #7600
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
/test pull-tekton-pipeline-build-tests |
1 similar comment
/test pull-tekton-pipeline-build-tests |
@Basavaraju-G: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -271,7 +271,7 @@ func imageNamesMapping() map[string]string { | |||
"registry": getTestImage(registryImage), | |||
"node": "node:alpine3.11", | |||
"gcr.io/cloud-builders/git": "alpine/git:latest", | |||
"docker:dind": "ibmcom/docker-s390x:20.10", | |||
"docker@sha256:74e78208fc18da48ddf8b569abe21563730845c312130bd0f0b059746a7e10f5": "ibmcom/docker-s390x:20.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to fix formatting with gofmt
. https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/7600/pull-tekton-pipeline-build-tests/1749843714966032384
Changes
#7496 This PR is updated the docker:dind image in the test examples. this is not multi arch image, its failing in s390x CI platforms, so use different image for s390x platform.
CI Failure:
https://dashboard.dogfooding.tekton.dev/#/namespaces/bastion-z/pipelineruns/tekton-pipeline-s390x-nightly-run-mnhzc?pipelineTask=examples-test-pipeline
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes