Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0076 (array results and indexing into array)promoted to stable #7542

Merged
merged 1 commit into from
Jan 19, 2024
Merged

TEP-0076 (array results and indexing into array)promoted to stable #7542

merged 1 commit into from
Jan 19, 2024

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Jan 3, 2024 •
edited
Loading

Changes

Pipelines 0.45 promoted array results and indexing into array param (proposed in TEP-0076) to beta. This commit is promoting these two features to stable such that these features can be used by the task authors and pipeline authors in a cluster when enable-api-fields is either set to alpha, beta or stable.

Closes #6816

/kind feature

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

TEP-0076 promoted to stable - Array results and indexing into an array is now possible with enable-api-fields set to stable.

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 3, 2024
@Yongxuanzhang
Copy link
Member Author

/test all

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jan 3, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.1

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review January 8, 2024 19:25
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@tekton-robot tekton-robot requested a review from dibyom January 8, 2024 19:26
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.4% 98.4% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.3% 98.3% -0.1

@chitrangpatel
Copy link
Contributor

/approve

@chitrangpatel chitrangpatel added this to the Pipelines v0.56 milestone Jan 9, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@Yongxuanzhang
TEP-0076 (array results and indexing into array)promoted to stable
b613ad5 
Pipelines 0.45 promoted array results and indexing into array param
(proposed in TEP-0076) to beta. This commit is promoting these two
features to stable such that these features can be used by the task
authors and pipeline authors in a cluster when enable-api-fields is
either set to alpha, beta or stable.

Closes tektoncd#6816

Signed-off-by: Yongxuan Zhang [email protected]
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.5% 98.5% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.4% 98.4% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.5% 98.5% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.4% 98.4% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% -0.0
pkg/apis/pipeline/v1/task_validation.go 98.5% 98.5% -0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 99.0% -0.0
pkg/apis/pipeline/v1beta1/task_validation.go 98.4% 98.4% -0.0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,chitrangpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot merged commit e1c7828 into tektoncd:main Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu approved these changes

@abayer abayer Awaiting requested review from abayer

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.56
Development

Successfully merging this pull request may close these issues.

Promote TEP-76 from Beta to Stable
5 participants
@Yongxuanzhang @tekton-robot @chitrangpatel @vdemeester @JeromeJu