Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0104] Task-level Resource Requirements to beta #7225

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[TEP-0104] Task-level Resource Requirements to beta #7225

merged 1 commit into from
Oct 20, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Oct 17, 2023 •
edited
Loading

Setting of Task-level Resource Requirements was introduced in v0.39.0. This is a crucial feature required by our customers when running Pipelines at large scale.

This promotes TEP-0104 to beta such that these features can be used by the task authors and pipeline authors in a cluster when enable-api-fields is either set to beta or alpha.
Fix #5490

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The task-level resource requirements feature allows the user to set computeResources at runtime i.e. on TaskRun. This is now enabled as part of the beta API.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 17, 2023
@tekton-robot tekton-robot requested review from abayer and wlynch October 17, 2023 15:51
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2023
@khrm
Copy link
Contributor Author

khrm commented Oct 17, 2023

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 17, 2023
@pritidesai pritidesai added this to the Pipelines v0.53 LTS milestone Oct 17, 2023
khrm
khrm commented Oct 18, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @vdemeester

vdemeester
vdemeester approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JeromeJu @jerop @Yongxuanzhang @dibyom @afrittoli

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
Yongxuanzhang
Yongxuanzhang approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we add an example under examples/v1/taskruns/beta ?

pkg/apis/pipeline/v1beta1/pipelinerun_validation_test.go Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 18, 2023
@khrm khrm force-pushed the tep-104-beta branch 2 times, most recently from 4a59252 to b12b673 Compare October 19, 2023 18:19
@khrm
[TEP-0104] Task-level Resource Requirements to beta
25a9d6a 
Setting of Task-level Resource Requirements was introduced in v0.39.0.
This is a crucial feature required by our customers when running
Pipelines at large scale.

This promotes TEP-0104 to beta such that these features can be used by
the task authors and pipeline authors in a cluster when enable-api-fields
is either set to beta or alpha.
jerop
jerop reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @khrm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@tekton-robot tekton-robot merged commit bb1155d into tektoncd:main Oct 20, 2023
2 checks passed
@khrm khrm deleted the tep-104-beta branch October 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@vdemeester vdemeester

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.53 LTS
Development

Successfully merging this pull request may close these issues.

[TEP-0104] Bring taskRun.spec.computeResources to beta
6 participants
@khrm @tekton-robot @vdemeester @jerop @Yongxuanzhang @pritidesai