Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poc: StepAction CRD (TEP 0142 - Enable Step reusability) #7124

Closed
wants to merge 6 commits into from

Conversation

chitrangpatel
Copy link
Contributor

Changes

This POC introduces a StepAction CRD as designed in tektoncd/community#1065.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind feature
/hold

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 18, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 18, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wlynch after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlynch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chitrangpatel chitrangpatel changed the title Poc step action Poc: StepAction CRD Sep 18, 2023
@chitrangpatel chitrangpatel changed the title Poc: StepAction CRD Poc: StepAction CRD (TEP 0142 - Enable Step reusability) Sep 18, 2023
@chitrangpatel chitrangpatel changed the title Poc: StepAction CRD (TEP 0142 - Enable Step reusability) POC: StepAction CRD (TEP 0142 - Enable Step reusability) Sep 18, 2023
@chitrangpatel chitrangpatel changed the title POC: StepAction CRD (TEP 0142 - Enable Step reusability) Pic: StepAction CRD (TEP 0142 - Enable Step reusability) Sep 18, 2023
@chitrangpatel chitrangpatel changed the title Pic: StepAction CRD (TEP 0142 - Enable Step reusability) Poc: StepAction CRD (TEP 0142 - Enable Step reusability) Sep 18, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.5% 12.1% -0.4
pkg/apis/pipeline/v1/task_validation.go 97.3% 92.3% -5.0
pkg/apis/pipeline/v1alpha1/openapi_generated.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/param_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/result_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go Do not exist N/A
pkg/apis/pipeline/v1alpha1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go Do not exist 0.0%
pkg/entrypoint/entrypointer.go 87.8% 81.0% -6.9
pkg/pod/entrypoint.go 89.8% 85.4% -4.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.5% 12.1% -0.4
pkg/apis/pipeline/v1/task_validation.go 97.3% 92.3% -5.0
pkg/apis/pipeline/v1alpha1/openapi_generated.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/param_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/result_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go Do not exist N/A
pkg/apis/pipeline/v1alpha1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go Do not exist 0.0%
pkg/pod/entrypoint.go 89.8% 85.4% -4.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.5% 12.1% -0.4
pkg/apis/pipeline/v1/task_validation.go 97.3% 92.3% -5.0
pkg/apis/pipeline/v1alpha1/openapi_generated.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/param_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/result_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go Do not exist N/A
pkg/apis/pipeline/v1alpha1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go Do not exist 0.0%
pkg/entrypoint/entrypointer.go 87.8% 81.0% -6.9
pkg/pod/entrypoint.go 89.8% 85.4% -4.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 12.5% 12.1% -0.4
pkg/apis/pipeline/v1/task_validation.go 97.3% 92.3% -5.0
pkg/apis/pipeline/v1alpha1/openapi_generated.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/param_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/result_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_conversion.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go Do not exist N/A
pkg/apis/pipeline/v1alpha1/stepaction_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go Do not exist 0.0%
pkg/pod/entrypoint.go 89.8% 85.4% -4.3

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests 806c5cd link true /test tekton-pipeline-unit-tests
pull-tekton-pipeline-build-tests 806c5cd link true /test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-integration-tests 806c5cd link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-alpha-integration-tests 806c5cd link true /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-beta-integration-tests 806c5cd link true /test pull-tekton-pipeline-beta-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jerop jerop added this to the Pipelines v0.53 milestone Sep 20, 2023
@dibyom
Copy link
Member

dibyom commented Oct 3, 2023

@chitrangpatel does it make sense to have this in the v0.53 milestone given that the TEP is in review?

@chitrangpatel
Copy link
Contributor Author

@chitrangpatel does it make sense to have this in the v0.53 milestone given that the TEP is in review?

I doubt it. May be 0.54 is probably more realistic. Also, this would probably make a giant PR since its a POC. I think I will be breaking it down into a couple of smaller PRs in the actual implementation.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@tekton-robot
Copy link
Collaborator

@chitrangpatel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerop jerop removed this from the Pipelines v0.54 milestone Nov 9, 2023
@jerop jerop closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants