Fixes RBAC permissions for task and pipeline runs for openshift #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `taskruns` or `pipelineruns` instance is created, build pod creation fails with following error `tekton-pipelines-controller` service account. ``` 'pods "hello-task-64f24-r9sgt" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: no RBAC policy matched, <nil>' ``` This patch fixes the required permission for `tekton-pipelines-admin` role, so controller could set required metadata on build pod. Fixes - knative/build#523
googlebot
added
the
cla: yes
knative-prow-robot
added
the
size/XS
hrishin
changed the title
knative-prow-robot
added
the
needs-ok-to-test
|
/ok-to-test |
knative-prow-robot
removed
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hrishin, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
savitaashture
pushed a commit
to savitaashture/pipeline
that referenced
this pull request
Jan 22, 2021
Add release-v0.19 yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
taskrunsorpipelinerunsinstance is created, build pod creationfails with the following error using
tekton-pipelines-controllerservice account.This patch fixes the required permission for
tekton-pipelines-adminrole,so controller could set required metadata/attributes on build pod.
Changes
Added more permissions to
tekton-pipelines-adminrole onTaskRunsandPipelineRunsresources.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.