Improve logs: Extra payload and open telemetry integration #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably you don't want to land this as such. But we improved your package with a few things, that might be breaking changes.
trace
to get thetraceID
integrate with OpenTelemetry and get it from the active Span (if any).logrus
. At least for us, that we use them a lot was a problem as lots of extra data was lost. To do it, instead of using thestruct
, it is using an intermediatemap
to be able to Marshal any possible field.On the way I downgraded OpenTelemetry to 1.25 because the vendor we use still hasn't yet update to the latest and does not yet implement all the new interfaces.
Up to discuss if we can agree on common grounds to make this available for everyone