feat: Allow endpoint url to be passed through to aws clients #48

mikeforkin · 2024-09-12T21:14:09Z

I am migrating from aws sso to teleport and connecting to ecs containers through a teleport proxy requires this configuration to be specified.

cmd/main.go

tedsmitt

Have tested locally using this branch, looks to work as expected. Approving.

internal/internal.go

tedsmitt · 2024-10-09T09:22:37Z

@mikeforkin if I was to remove the enable-env flag and then allow optional parameters to be passed via prefixed env vars e.g. ECSGO_AWS_ENDPOINT_URL, ECSGO_CLUSTER etc. Would that also work for your use case?

mikeforkin commented Sep 12, 2024

View reviewed changes

cmd/main.go Outdated Show resolved Hide resolved

feat: Allow endpoint url to be passed through to aws clients

68e578d

mikeforkin force-pushed the f_endpoint_url branch from c915af1 to 68e578d Compare September 16, 2024 14:59

Updating env population of cli args to be behind a cli flag.

1b08280

mikeforkin force-pushed the f_endpoint_url branch from ec8e540 to 1b08280 Compare September 22, 2024 03:40

mikeforkin requested a review from tedsmitt September 26, 2024 16:53

tedsmitt approved these changes Oct 9, 2024

View reviewed changes

internal/internal.go Show resolved Hide resolved

tedsmitt merged commit c3beef8 into tedsmitt:main Oct 9, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Allow endpoint url to be passed through to aws clients #48

feat: Allow endpoint url to be passed through to aws clients #48

mikeforkin commented Sep 12, 2024

tedsmitt left a comment

tedsmitt commented Oct 9, 2024

feat: Allow endpoint url to be passed through to aws clients #48

feat: Allow endpoint url to be passed through to aws clients #48

Conversation

mikeforkin commented Sep 12, 2024

tedsmitt left a comment

Choose a reason for hiding this comment

tedsmitt commented Oct 9, 2024