-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added question iteration. #20
Conversation
321c9ea
to
41e723e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good job on this one - especially given the fact you also scoped the ticket yourselves
|
||
const question = questions[Math.floor(Math.random() * questions.length)]; | ||
export function QuestionDisplay(props: QuestionDisplayProp) { | ||
// const questions = getQuizQuestions(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving old code in as comments creates a risk of confusion when it comes to re-reading/updating the code.
please remove these
<input type="radio" name="answer" id="radio-button1" value="0" /> {props.question.answers[0].answer} <br/> | ||
<input type="radio" name="answer" id="radio-button2" value="1" /> {props.question.answers[1].answer} <br/> | ||
<input type="radio" name="answer" id="radio-button3" value="2" /> {props.question.answers[2].answer} <br/> | ||
{/* <button type="submit" className="submit-answer" onClick={() => updateCurrentIndex() }>Submit</button> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above please can this comment be removed from this PR
Implemented navigating through all questions
Screenshots - for changes to the UI
Things to Check