Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic stylesheet #2

Merged
merged 3 commits into from
Jul 30, 2024
Merged

basic stylesheet #2

merged 3 commits into from
Jul 30, 2024

Conversation

bobbybwoy
Copy link
Collaborator

Created a basic stylesheet that includes colours and basic text formatting

There are no screenshots

Things to Check

  • Have all the requirments of your ticket have been met - this is a work-in-progress
  • Have you added tests if needed for your ticket - no tests have been added
  • Are all the tests passing - N/A

Kiran-R-K
Kiran-R-K reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good - I've left a question about naming (feel free to let me know if you disagree with my comment - this can be a conversation)
you marked this as an in progress review in your description so let me know when it's ready for a final review

Kiran-R-K
Kiran-R-K reviewed Jul 30, 2024
View reviewed changes
src/App.scss Outdated Show resolved Hide resolved
Kiran-R-K
Kiran-R-K approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - ready to merge

@sun-amy sun-amy merged commit 618896a into main Jul 30, 2024
1 check passed
@sun-amy sun-amy deleted the MM.003_create_a_basic_stylesheet branch July 31, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiran-R-K Kiran-R-K Kiran-R-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobbybwoy @Kiran-R-K @sun-amy