Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm 002 quiz questions #11

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Mm 002 quiz questions #11

merged 5 commits into from
Jul 31, 2024

Conversation

RuksanEmirali
Copy link
Collaborator

Description of changes - what did you do

Find questions from Nasa website
Create tsx file with a function which returns questions
Create answer and question types
Store the questions and answer as an array of objects using types created.
Export function
Create tests that checks function is returning data and questions and answers can be accessed.

Screenshots - for changes to the UI

Things to Check

  • Have all the requirments of your ticket have been met
  • Have you added tests if needed for your ticket
  • Are all the tests passing

Sorry, something went wrong.

@RuksanEmirali RuksanEmirali requested a review from Kiran-R-K July 31, 2024 14:25
Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and easy to read - really nice work.

I've just left 1 request to remove some comments - I'm going to approve the PR now and when you push that change feel free to merge this branch straight in (as long as the pipeline passes)

@@ -0,0 +1,82 @@
// 1. Where is Mars in the solar system?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleaser can you remove these comments - it's not necessary to keep them there now the answers have been hardcoded

@@ -0,0 +1,21 @@
import { getQuizQuestions } from "./getQuizQuestions";

test('quiz questions are returned by the function', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests :)

@RuksanEmirali RuksanEmirali merged commit 692231c into main Jul 31, 2024
1 check passed
@Kiran-R-K Kiran-R-K deleted the mm-002-quiz-questions branch August 2, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants