Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick kube-vip interface automatically by default #238

Merged

Conversation

sleiner
Copy link
Contributor

@sleiner sleiner commented Feb 18, 2023

Proposed Changes

  • Currently, it is not possible to use multiple control nodes where the network interfaces to use have different names. This is due to the fact that {{ flannel_iface }} of the first control node will be hardcoded into the kube-vip manifest as the interface that all kube-vip pods must use.
  • kube-vip is able to pick a matching interface per pod automatically for a "long time".
  • This patch enables the automatic choice of interface by default and offers users the ability to override the interface if they want to (independently of flannel_iface, as requested in More customisation / overrides for kube-vip #221.

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

@timothystewart6 timothystewart6 enabled auto-merge (squash) February 20, 2023 03:35
@timothystewart6
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants