Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select soil #2514

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: select soil #2514

wants to merge 14 commits into from

Conversation

tm-ruxandra
Copy link
Contributor

Description

Add the ability to select a soil ID match from the Soil Info sheet. The selected match will display above the list of matches in the soil ID screen and will take precedence over the top match for the dashboard screen's location soil ID info card. The selection is stored in a new "Soil Metadata" model. Selection read/write is exposed through a hook.

Also refactor some nearby code for ease of making changes.

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

#2506

Verification steps

Select a site and mark its selected soil ID match. Verify that the match is visible on both the dashboard and soil ID screens. Select another match and verify that the displayed match changes. Un-select the match and verify that the top match is displayed instead.

@tm-ruxandra
Copy link
Contributor Author

I don't know why integration tests are failing with a parse error - it appears to be a consequence of the changes to terraso-client-shared, but I can't reason about it beyond that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants