-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select soil #2514
Open
tm-ruxandra
wants to merge
14
commits into
main
Choose a base branch
from
feat/select-soil-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: select soil #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-client/src/screens/LocationScreens/components/soilInfo/SoilIdMatchSelector.tsx
Show resolved
Hide resolved
I don't know why integration tests are failing with a parse error - it appears to be a consequence of the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to select a soil ID match from the Soil Info sheet. The selected match will display above the list of matches in the soil ID screen and will take precedence over the top match for the dashboard screen's location soil ID info card. The selection is stored in a new "Soil Metadata" model. Selection read/write is exposed through a hook.
Also refactor some nearby code for ease of making changes.
Checklist
Related Issues
#2506
Verification steps
Select a site and mark its selected soil ID match. Verify that the match is visible on both the dashboard and soil ID screens. Select another match and verify that the displayed match changes. Un-select the match and verify that the top match is displayed instead.