Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to ECS tasks #724

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

nickhurlburt
Copy link
Collaborator

Goal

I want to be able to track our AWS spend by environment (eg prod/staging/dev). This is easy to do when our AWS resources all have an Environment tag.

One of our major costs is our running ECS tasks for HRM and the job processor. For some weird reason, it seems that in order to divide costs, the tasks themselves need to be tagged. Tagging the clusters or services is insufficient.

I have manually added a tag here and it seems to be tracking costs as desired.

image

This draft PR is my attempt to have these tags created as part of our automated deploys. I could use a little help from someone in seeing if this is correct and testing it out.

Checklist

  • Corresponding issue has been opened
  • [n/a] New tests added
  • [n/a] Feature flags / configuration added

Verification steps

  • After a deploy, check that the ECS tasks for HRM and the job processor have the appropriate tags.
  • After a couple days, look at the billing and cost explorer in AWS to confirm that ECS charges are correctly categorized.

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant