chore: improve messaging

techmatters · Nov 14, 2024 · 020057d · 020057d
1 parent 8bd09a1
commit 020057d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 18 deletions.
diff --git a/hrm-domain/hrm-core/case/caseReindexService.ts b/hrm-domain/hrm-core/case/caseReindexService.ts
@@ -68,14 +68,14 @@ export const reindexCasesStream = async (
           });
 
           this.push(
-            `${new Date().toISOString()},${accountSid},contad id: ${
+            `${new Date().toISOString()}, ${accountSid}, case id: ${
               caseObj.id
             } Success, MessageId ${MessageId}
               \n`,
           );
         } catch (err) {
           this.push(
-            `${new Date().toISOString()},${accountSid},contad id: ${caseObj.id} Error: ${
+            `${new Date().toISOString()}, ${accountSid}, case id: ${caseObj.id} Error: ${
               err.message?.replace('"', '""') || String(err)
             }\n`,
           );

diff --git a/hrm-domain/hrm-core/contact/contactsReindexService.ts b/hrm-domain/hrm-core/contact/contactsReindexService.ts
@@ -60,16 +60,16 @@ export const reindexContactsStream = async (
           });
 
           this.push(
-            `${new Date().toISOString()},${accountSid},contad id: ${
+            `${new Date().toISOString()}, ${accountSid}, contact id: ${
               contact.id
             } Success, MessageId ${MessageId}
               \n`,
           );
         } catch (err) {
           this.push(
-            `${new Date().toISOString()},${accountSid},contad id: ${contact.id} Error: ${
-              err.message?.replace('"', '""') || String(err)
-            }\n`,
+            `${new Date().toISOString()}, ${accountSid}, contact id: ${
+              contact.id
+            } Error: ${err.message?.replace('"', '""') || String(err)}\n`,
           );
         }
         callback();

diff --git a/packages/elasticsearch-client/src/client.ts b/packages/elasticsearch-client/src/client.ts
@@ -67,17 +67,12 @@ export type PassThroughConfig<T> = {
   client: EsClient;
 };
 
-const getConfigSsmParameterKey = (indexType: string) =>
-  `/${process.env.NODE_ENV}/${indexType}/${process.env.AWS_REGION}/elasticsearch_config`;
-
 //TODO: type for config
 const getEsConfig = async ({
   config,
-  indexType,
   ssmConfigParameter,
 }: {
-  config: ClientOptions | undefined;
-  indexType: string;
+  config?: ClientOptions | undefined;
   ssmConfigParameter?: string;
 }) => {
   console.log('config', config);
@@ -102,8 +97,7 @@ const getEsConfig = async ({
     return JSON.parse(await getSsmParameter(ssmConfigParameter));
   }
 
-  // TODO: remove this if it's not used anymore?
-  return JSON.parse(await getSsmParameter(getConfigSsmParameterKey(indexType)));
+  throw new Error(`getEsConfig error: no valid config provided to initialize client`);
 };
 
 /**
@@ -123,7 +117,6 @@ export type IndexClient<T> = {
 const getClientOrMock = async ({
   config,
   index,
-  indexType,
   ssmConfigParameter,
 }: GetClientOrMockArgs) => {
   // TODO: mock client for unit tests
@@ -132,9 +125,7 @@ const getClientOrMock = async ({
   //   return mock;
   // }
 
-  const client = new EsClient(
-    await getEsConfig({ config, indexType, ssmConfigParameter }),
-  );
+  const client = new EsClient(await getEsConfig({ config, ssmConfigParameter }));
   return {
     client,
     index,