-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[이승환] 기능구현 챌린지 #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tmdghks7305
style: 안쓰는 코드 삭제
Tmdghks7305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설계의 방향성
고민사항
컴포넌트 재사용을 할 수 있으면 무조건 하면 좋은지
컴포넌트를 재사용 할 수록 코드의 복잡도가 늘어나서 힘들었어요.
마음편하게 컴포넌트를 여러개 만드는 것도 방법이라고 생각하는데 기준이 있을까요?
비즈니스 로직과 뷰 로직을 커스텀 훅을 사용해 어떤 기준으로 얼마나 분리해야하는지
문제는 컴포넌트가 많아지면서 많은 곳에서 상태를 관리해야 했었고 상위에 있는 커스텀 훅에서 로직을 작성해 내려줘야했는데 그거 때문에
depth가 깊어졌어요.
해결 방법은 컴포넌트마다 커스텀 훅을 작성해 해결할 수 있다고 생각합니다. 근데 커스텀 훅을 부담없이 1회성으로 많이 만들어도 될까요?
브라우저 저장소 (로컬,세션,캐시) 스토리지중에 결과리스트,최근 검색리스트를 어디에 저장할지
리드미 링크:https://github.com/Leeseunghwan7305/Infinite_Challenge_FE