Skip to content

Commit

Permalink
Merge pull request #186 from techdivision/pac-354
Browse files Browse the repository at this point in the history
PAC-354: Add new Callback to validate store-view and website
  • Loading branch information
kenza-ya authored Jul 16, 2024
2 parents 2dfc6b5 + 342b6a0 commit affb2f3
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 5 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# Version 25.3.3

## Bugfixes

* None

## Features

* Add #PAC-354 new feature:
* extend the validation for catalog_product entity
* `"import.callback.store.in.website.validator"`

# Version 25.3.2

## Bugfixes
Expand Down
5 changes: 4 additions & 1 deletion etc/configuration/operations.json
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,10 @@
"callbacks": [
{
"sku": [ "import.callback.custom.regex.validator" ],
"store_view_code": [ "import.callback.store.view.code.validator" ],
"store_view_code": [
"import.callback.store.view.code.validator",
"import.callback.store.in.website.validator"
],
"attribute_set_code": [ "import.callback.attribute.set.name.validator" ],
"product_type": [ "import_product.callback.validator.product_type" ],
"tax_class_id": [ "import_product.callback.validator.tax.class" ],
Expand Down
8 changes: 4 additions & 4 deletions symfony/Resources/config/services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,8 @@
</service>

<!--
| The DI configuration for the black hole enabled URL rewrite action because
| we do NOT want to persist the URL rewrites here, we ONLY want tempoarily
| The DI configuration for the black hole enabled URL rewrite action because
| we do NOT want to persist the URL rewrites here, we ONLY want tempoarily
| add them to cache used to make sure we generate unique request paths
|-->
<service id="import_product.action.wrapped.url.rewrite" class="TechDivision\Import\Dbal\Collection\Actions\GenericIdentifierAction">
Expand All @@ -472,7 +472,7 @@
<argument type="service" id="import.events.emitter"/>
<argument type="service" id="import_product.action.wrapped.url.rewrite"/>
<argument type="service" id="import_product.cache.key.url.rewrite"/>
</service>
</service>

<!--
| The DI configuration for the assemblers
Expand Down Expand Up @@ -851,4 +851,4 @@

</services>

</container>
</container>

0 comments on commit affb2f3

Please sign in to comment.