Code inspection

teccheck · May 15, 2023 · b2d3b20 · b2d3b20
1 parent 95a04c7
commit b2d3b20
Show file tree

Hide file tree

Showing 16 changed files with 11 additions and 36 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -38,7 +38,7 @@ android {
 }
 
 dependencies {
-    implementation 'androidx.core:core-ktx:1.10.0'
+    implementation 'androidx.core:core-ktx:1.10.1'
     implementation 'androidx.appcompat:appcompat:1.6.1'
     implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
     implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.6.1'
@@ -48,7 +48,7 @@ dependencies {
     implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
     implementation 'androidx.preference:preference-ktx:1.2.0'
 
-    implementation 'com.google.android.material:material:1.8.0'
+    implementation 'com.google.android.material:material:1.9.0'
     implementation 'com.google.code.gson:gson:2.10'
 
     implementation 'com.squareup.picasso:picasso:2.8'

diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsApiException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsApiException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-abstract class LyricsApiException {
-}
+abstract class LyricsApiException
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class LyricsNotFoundException : LyricsApiException() {
-}
+class LyricsNotFoundException : LyricsApiException()
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NetworkException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NetworkException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class NetworkException : LyricsApiException() {
-}
+class NetworkException : LyricsApiException()
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class NoMusicPlayingException : LyricsApiException() {
-}
+class NoMusicPlayingException : LyricsApiException()
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/ParseException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/ParseException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class ParseException : LyricsApiException() {
-}
+class ParseException : LyricsApiException()
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt b/app/src/main/java/io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt
@@ -12,7 +12,7 @@ import com.squareup.picasso.Picasso
 import io.github.teccheck.fastlyrics.R
 import io.github.teccheck.fastlyrics.model.SongWithLyrics
 
-class RecyclerAdapter() :
+class RecyclerAdapter :
     RecyclerView.Adapter<RecyclerAdapter.ViewHolder>() {
 
     private var songs: List<SongWithLyrics> = listOf()

diff --git a/app/src/main/res/values-land/dimens.xml b/app/src/main/res/values-land/dimens.xml
diff --git a/app/src/main/res/values-w1240dp/dimens.xml b/app/src/main/res/values-w1240dp/dimens.xml
diff --git a/app/src/main/res/values-w600dp/dimens.xml b/app/src/main/res/values-w600dp/dimens.xml
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
@@ -8,8 +8,5 @@
     <color name="theme_on_secondary">#ffffff</color>
 
     <color name="theme_background_dark">#202124</color>
-    <color name="nav_bar_color">#52000000</color>
 
-    <color name="black">#FF000000</color>
-    <color name="white">#FFFFFFFF</color>
 </resources>
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -1,8 +1,4 @@
 <resources>
     <!-- Default screen margins, per the Android Design guidelines. -->
     <dimen name="activity_horizontal_margin">16dp</dimen>
-    <dimen name="activity_vertical_margin">16dp</dimen>
-    <dimen name="nav_header_vertical_spacing">8dp</dimen>
-    <dimen name="nav_header_height">176dp</dimen>
-    <dimen name="fab_margin">16dp</dimen>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -2,10 +2,6 @@
     <string name="app_name">FastLyrics</string>
 
     <!-- Nav drawer -->
-    <string name="navigation_drawer_open">Open navigation drawer</string>
-    <string name="navigation_drawer_close">Close navigation drawer</string>
-    <string name="nav_header_desc">Navigation header</string>
-    <string name="nav_header_icon_desc">Navigation header icon</string>
 
     <string name="menu_lyrics">Lyrics</string>
     <string name="menu_saved">Saved</string>

diff --git a/build.gradle b/build.gradle
@@ -5,7 +5,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.0.0'
+        classpath 'com.android.tools.build:gradle:8.0.1'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.0'
 
         // NOTE: Do not place your application dependencies here; they belong

diff --git a/gradle.properties b/gradle.properties
@@ -20,5 +20,5 @@ android.enableJetifier=true
 # Kotlin code style for this project: "official" or "obsolete":
 kotlin.code.style=official
 android.defaults.buildfeatures.buildconfig=true
-android.nonTransitiveRClass=false
+android.nonTransitiveRClass=true
 android.nonFinalResIds=false
diff --git a/settings.gradle b/settings.gradle
@@ -3,7 +3,7 @@ dependencyResolutionManagement {
     repositories {
         google()
         mavenCentral()
-        jcenter() // Warning: this repository is going to shut down soon
+         // Warning: this repository is going to shut down soon
     }
 }
 rootProject.name = "FastLyrics"