add func 'NewIEDriverService' for simply support call IEDriverService #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minusnine
reviewed
Jun 30, 2021
| @@ -221,6 +221,19 @@ func NewGeckoDriverService(path string, port int, opts ...ServiceOption) (*Servi | |||
| return s, nil | |||
| } | |||
|
|
|||
| // NewIEDriverService starts a IEDriverServer instance in the background. | |||
| func NewIEDriverService(path string, port int, opts ...ServiceOption) (*Service, error) { | |||
There was a problem hiding this comment.
To properly support this, this needs tests, which is not a small undertaking:
- A new top-level test function needs to be added to selenium_test.go, called
TestInternetExplorer, similar to the other tests in that file. - Somehow, we'll need to skip that test if it isn't executed on Windows.
- We should add a run on Travis in Windows environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add func 'NewIEDriverService' for simply support call IEDriverService