Add GenericTargetFactory and related configuration
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
force-pushed
the
generic-target-factory
branch
2 times, most recently
from
9188ab4 to
e8b937e
Compare
|
Converted to draft until #37 is merged. |
mike4git
reviewed
Jan 31, 2023
jdreesen
force-pushed
the
generic-target-factory
branch
2 times, most recently
from
9d6d352 to
c749382
Compare
|
I think my idea about "Single-level-of-abstraction" force to implement several private methods which would be readable and "documents" what would be done in each step: and of course there could be some more private "helper" methods which checks if a field is set and defined or do the registration. |
|
This is currently on hold until #41 is done. |
DerNoopPro
pushed a commit
that referenced
this pull request
Apr 18, 2024
mike4git
force-pushed
the
generic-target-factory
branch
from
4f54276 to
9ac6c99
Compare
mike4git
added a commit
that referenced
this pull request
Apr 18, 2024
mike4git
added a commit
that referenced
this pull request
Apr 18, 2024
…ase for Converter with target option
mike4git
added a commit
that referenced
this pull request
Apr 18, 2024
I like that much more... Co-authored-by: Jacob Dreesen <[email protected]>
…ase for Converter with target option
jdreesen
force-pushed
the
generic-target-factory
branch
from
0a450a0 to
f352d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
GenericTargetFactory, which means you can skip writing your ownTargetTypeFactoryand just configure yourtargettype if nothing more is needed thannew MyTargetType().