Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a whenHeld to a custom trigger class #162

Open
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

TechplexEngineer
Copy link
Member

If/When they merge wpilibsuite/allwpilib#1643 we can remove this shim

Copy link
Contributor

@derrell derrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about this. I think it's a bad idea to be mixing use of BionicTrigger and Trigger. We should use native stuff, or use our own wrapper, but not both. How about adding the required functionality included here into BionicTrigger?

@roshanr10
Copy link
Contributor

if we're going to be doing this, why don't we inherit BionicTrigger from Trigger so they're more interchangeable? if your PR goes through, then it'll become native and no changes to be made

@TechplexEngineer
Copy link
Member Author

@roshanr10 It would be good for someone to try to extend Trigger, but I was running into access issues. Please do try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants