YEL-193 [feat] 친구 쪽지 전체 조회하기 #421
Conversation
| .id(vote.getId()) | ||
| .senderId(vote.getSender().getId()) | ||
| .senderName(vote.getSender().getName()) | ||
| .senderGender(vote.getSender().getGender().name()) |
There was a problem hiding this comment.
차후 ENUM 점검할 때 getInitial()로 변경할 수 있도록 합시다
| List<VoteFriendAndUserVO> list = | ||
| voteRepository.findUserSendReceivedByFriends(userId, pageable) | ||
| .stream() | ||
| .filter(vote -> vote.getNameHint()!=-3) |
There was a problem hiding this comment.
NameHint도 ENUM화 시켰으면 좋을텐데 말이죠
(처음만든게 아쉬운게 보여서 아쉽다고하는 리뷰)
There was a problem hiding this comment.
그러게요 ㅎ... 숫자로 하니까 의미가 뚜렷하게 보이지 않아서 오랜만에 보니 또 헤깔리네유
| @@ -113,6 +119,32 @@ public VoteFriendResponse findAllFriendVotes(Long userId, Pageable pageable) { | |||
| return VoteFriendResponse.of(totalCount, list); | |||
| } | |||
|
|
|||
| public VoteFriendAndUserResponse findAllFriendVotesWithType(Long userId, Pageable pageable, String type) { | |||
|
|
|||
| if(type.equals(USER_VOTE_TYPE)) { | |||
| @@ -113,6 +119,32 @@ public VoteFriendResponse findAllFriendVotes(Long userId, Pageable pageable) { | |||
| return VoteFriendResponse.of(totalCount, list); | |||
| } | |||
|
|
|||
| public VoteFriendAndUserResponse findAllFriendVotesWithType(Long userId, Pageable pageable, String type) { | |||
There was a problem hiding this comment.
ENUM을 통해 type을 narrowing해주고,
StringUtils.hasText(); 통해 null처리를 해주세요
There was a problem hiding this comment.
String type -> VoteType type으로 바꿔주세요
| public BaseResponse<KeywordCheckResponse> checkKeyword(@PathVariable Long voteId, @AccessTokenUser User user) { | ||
| @GetMapping("/v2/vote/friend") | ||
| public BaseResponse<VoteFriendAndUserResponse> findAllFriendVotesWithType( | ||
| @RequestParam("page") Integer page, @RequestParam("type") String type, |
There was a problem hiding this comment.
아래와 같이 type을 Nullable하게 만들고,
@RequestParam(value = "type", required = false) String typehttps://github.com/team-yello/YELLO-Server/blob/feat/YEL-187/src/main/java/com/yello/server/domain/admin/controller/AdminController.java#L156
을 참조해서 ENUM 처리를 해주세요
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum VoteType { | ||
| send("send"); |
| @@ -113,6 +119,32 @@ public VoteFriendResponse findAllFriendVotes(Long userId, Pageable pageable) { | |||
| return VoteFriendResponse.of(totalCount, list); | |||
| } | |||
|
|
|||
| public VoteFriendAndUserResponse findAllFriendVotesWithType(Long userId, Pageable pageable, String type) { | |||
There was a problem hiding this comment.
String type -> VoteType type으로 바꿔주세요
☘️ Related Issue
✅ Work description
💡 PR point