Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement debug output for file and websocket #352

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: implement debug output for file and websocket #352

merged 1 commit into from
Apr 26, 2024

Conversation

farhat-ha
Copy link
Collaborator

XXXX-YYY

Describe your changes

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Provide manual testing instructions

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
usage.gif

DeividVeloso
DeividVeloso approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@DeividVeloso DeividVeloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

enzoqtvf
enzoqtvf reviewed Apr 26, 2024
View reviewed changes
Copy link

@enzoqtvf enzoqtvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small question regarding the default value of debug

Also probably we want to add extra documentation regarding what it does. this can be added later though

packages/js/README.md Outdated Show resolved Hide resolved
@farhat-ha farhat-ha merged commit 8d1f8e6 into main Apr 26, 2024
2 checks passed
@farhat-ha farhat-ha deleted the haythem/debugging branch April 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enzoqtvf enzoqtvf enzoqtvf left review comments

@DeividVeloso DeividVeloso DeividVeloso approved these changes

@ericaprieto ericaprieto Awaiting requested review from ericaprieto ericaprieto is a code owner automatically assigned from team-telnyx/frontend

@lmao12 lmao12 Awaiting requested review from lmao12 lmao12 is a code owner automatically assigned from team-telnyx/frontend

@jonathan-telnyx jonathan-telnyx Awaiting requested review from jonathan-telnyx jonathan-telnyx is a code owner automatically assigned from team-telnyx/frontend

@priscillasantana priscillasantana Awaiting requested review from priscillasantana priscillasantana is a code owner automatically assigned from team-telnyx/frontend

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farhat-ha @DeividVeloso @enzoqtvf