Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENGDESK-28811): call object direction is undefined upon receiving call #341

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

farhat-ha
Copy link
Collaborator

Describe your changes

The direction is set to Inbound upon receiving an Invite message.

Not sure if this is the best approach. Feedback appreciated

WIP: tests.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Provide manual testing instructions

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
usage.gif

@farhat-ha farhat-ha self-assigned this Feb 21, 2024
@farhat-ha farhat-ha marked this pull request as ready for review February 21, 2024 09:27
Copy link
Contributor

@DeividVeloso DeividVeloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhat-ha farhat-ha merged commit 8ac5a3f into main Feb 21, 2024
2 checks passed
@farhat-ha farhat-ha deleted the haythem/ENGDESK-28811 branch February 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants