Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

댓글 바텀시트 구현 #83

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Conversation

Jinho1011
Copy link
Member

2023-12-07.20.08.04.mov

댓글 바텀시트를 구현했습니다.

추후 댓글 영역 구현하면서 사이드 이펙트 발견 시 바텀시트 쭉 손봐야 할 것으로 예상됨

인터페이스는 아래와 같음

interface BottomSheetProps {
  open: boolean;
  setIsOpen: React.Dispatch<React.SetStateAction<boolean>>;
  snapPoints?: number[];
  initialSnap?: number;
  children: React.ReactNode;
}

setIsOpen 대신에 closeSheet 사용하는 것은 어떤지

@Jinho1011 Jinho1011 merged commit 21eb18d into dev Dec 7, 2023
1 check passed
@Jinho1011 Jinho1011 deleted the feat/topic-comment-bottom-sheet branch December 7, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant