Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiper #65

Merged
merged 5 commits into from
Dec 2, 2023
Merged

Fix swiper #65

merged 5 commits into from
Dec 2, 2023

Conversation

Jinho1011
Copy link
Member

2023-12-01.19.13.45.mov

swiper와 관련된 로직을 Home에서 제거하고 TopicSwiper를 구현해 사용했습니다.

Home이 이렇게 간결해졌어요

const Home = () => {
  return (
    <Layout HeaderRight={() => <NotificationButton />}>
      <Container>
        <TopicSwiper>
          <TopicCard />
          <TopicCard />
          <TopicCard />
        </TopicSwiper>
      </Container>
    </Layout>
  );
};

TopicSwiper에서 swiper나 slide prev/next button을 전부 구현했습니다!

다만 우선 버튼 위치를 absolutetop: 110px; left or right: 20px
이렇게 고정시켜놨는데 이 부분은 추후 수정이 필요하게 될 것 같습니다.

@Jinho1011 Jinho1011 added feature Implement new feature enhancement labels Dec 1, 2023
@Jinho1011 Jinho1011 added this to the Sprint 5 milestone Dec 1, 2023
@Jinho1011 Jinho1011 self-assigned this Dec 1, 2023
@Jinho1011 Jinho1011 merged commit 3f6c4e9 into dev Dec 2, 2023
1 check passed
@Jinho1011 Jinho1011 deleted the fix/swiper branch December 3, 2023 05:59
@Jinho1011 Jinho1011 linked an issue Dec 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implement new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

홈 화면 AB 슬라이더 구현
1 participant