Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/topic create page #135

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Feat/topic create page #135

merged 8 commits into from
Jan 10, 2024

Conversation

chaeyoung103
Copy link
Collaborator

홈화면에서 토픽생성페이지로 넘어갈 수 있도록 로직을 추가 하였습니다.
#51

@chaeyoung103 chaeyoung103 self-assigned this Jan 10, 2024
@chaeyoung103 chaeyoung103 added the feature Implement new feature label Jan 10, 2024
src/components/commons/Header/CloseButton/CloseButton.tsx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AButton과 BButton에 중복되는 속성들이 많은데 이를 SideButton이라는 이름으로 styled 객체를 만들고 AButton과 BButton을 styled(SideButton)으로 상속 받는 것처럼 만들면 어떨까요?

@Jinho1011 Jinho1011 merged commit bc1b5f0 into dev Jan 10, 2024
1 check passed
@Jinho1011 Jinho1011 deleted the feat/topic-create-page branch January 10, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implement new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants