Fix "Device information ... not found" errors with modern libwacom versions #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2023 19:54
Depending on how old the version of libwacom, most likely no devices will ever be detected. libwacom-list-local-devices, since April 28, 2021 (release 1.10, see ref. below) uses the YAML format by default, which looks like: ``` $ libwacom-list-local-devices --database /usr/share/libwacom/ devices: - name: 'Wacom Intuos Pro L' bus: 'usb' vid: '0x056a' pid: '0x0317' nodes: - /dev/input/event30 - /dev/input/event29 - /dev/input/event28 ``` ...while wacom-gui expects a different format, thus the parsing is wrong, and the 'detected' dictionary in get_connected_tablets() is wrong and an exception is thrown. To get the format expected by wacom-gui, we need to add the `--format=datafile` argument. In addition, we are quoting the '%s' to avoid an exception in a case where the path would have spaces. NOTE: this change breaks compatibility with libwacom < 1.10. See libwacom's project commit referenced below. References: - libwacom commit linuxwacom/libwacom@68c0ba5 "tools: use a YAML-compatible format by default" - https://github.com/linuxwacom/libwacom/releases/tag/libwacom-1.10
libwacom 1.10 introduced a breaking change to the output format of libwacom-list-local-devices. Commit a480df1 makes us compatible with the new format, at the expense of breaking compatibility with older versions. This commit reintroduces compatibility with BOTH versions. The strategy is to first try running libwacom-list-local-devices with the new syntax, and fall back to the old syntax if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #68, by adding compatibility with libwacom >= 1.10, while maintaining compatibility with older versions.
This fixes wacom-gui compatibility with:
In particular, I've tested this on Ubuntu 22.04 LTS. By the way, the necessary dependencies for Ubuntu are: libwacom-bin, xserver-xorg-input-wacom, python3-pyqt5, python3-pyqt5.qtsvg in case you want to add them to the README. libwacom-bin is the Ubuntu and Debian equivalent to libwacom in RPM systems, e.g. libwacom-2.7.0-1.fc38.x86_64.rpm for Fedora 38.