Allow developers to define #call with arguments for convenience #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the "call" instance method accepts arguments, those arguments will be automatically assigned from the provided context, matching on name. This works for both positional and keyword arguments. If an argument is specified but no matching value is provided in the context, an ArgumentError is raised.
This also improves performance of the Interactor#arguments_for_call method by not duplicating the table of data held internally by the context. As a happy side effect, this adds the Interactor::Context#include? method which may be helpful for developers.
…by not interacting directly with OpenStruct#modifiable.
There were edge cases that weren't yet covered by the specs that would
fail for combinations of positional and keyword arguments depending on
what's available in the context. For example:
class MyInteractor
include Interactor
def call(a, b: "bears")
context.output = [a, b]
end
end
MyInteractor.call(b: "beets").output # => [{ b: "beets" }, "bears"]
Plus, this simplifies the interface by giving the developer one choice
rather than multiple competing choices that achieve the same thing.
|
Is this dead? This is by far my biggest issue with the library, and some sort of interface definition would greatly help our team use interactors more cleanly and safely. |
|
@corytheboyd-cirrusmd I stopped working on this PR and the main "modernize" PR for interactor because there is just zero communication from the maintainers. 😞 I have since forked interactor and changed some things, mostly around restricting interactor inputs and outputs to predefined variables. It's not a drop-in replacement though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of collectiveidea#135.
Required because of how outdated the upstream
v4branch is, this is basically the same PR but rebased onto the updatedv4branch.