feat(macos): register media keys #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Apr 23, 2024
amrbashir
requested changes
Apr 23, 2024
src/platform_impl/macos/mod.rs
Outdated
Comment on lines
163
to
164
| self.media_hotkeys.lock().unwrap().remove(&hotkey); | ||
| if self.media_hotkeys.lock().unwrap().is_empty() { |
There was a problem hiding this comment.
why lock twice, let's lock once and assign to a variable
amrbashir
approved these changes
Apr 23, 2024
amrbashir
added a commit
that referenced
this pull request
Apr 23, 2024
* feat: support registering media play/pause/stop/next/prev keys closes #70 * feat(macos): register media keys (#72) * feat(macos): register media keys * chore: update documents * organize codes * fix: using RefCell for event_tap * docs: remove mut from GlobalHotKeyManager::new() * use mutex and stop watching media keys on drop --------- Co-authored-by: Jason Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibilitypermission request when registering media hotkey.