fix: populate-user-agent-header #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
requested changes
Oct 24, 2024
There was a problem hiding this comment.
I don't think we need different user-agents per adapter github/tor/binary download. All the agents could just say universe with version and platform, and if this is the case it could be a static var instead of defined per file.
/cc @leet4tari opinions?
| "universe {}({}) | {}", | ||
| env!("CARGO_PKG_VERSION"), | ||
| std::env::consts::OS, | ||
| "github adapter" |
There was a problem hiding this comment.
Should this say "tor adapter" ?
Suggested change
| "github adapter" | |
| "tor adapter" |
There was a problem hiding this comment.
Agree, only TU version and platform info I think is useful. Getting reports on TU version or platform usage from CDN provider is possible. Different adapter would not request resources from different services.
|
Closing in favor of #935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#905
[ Content ]
Added User-agent header to request that had it missing or was not descriptive