Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): global font and font faces #780

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Oct 9, 2024

Description

  • update Tower Animation canvas background gradient colours
  • fix global fonts:
    • specify Druk Wide and use narrow Druk for the gem earnings animation
    • use correct font family name set in font-fae for Poppins in the GlobalStyles
  • adjust BlockHeightAccent Ruler styling to suit comments from the UI QA runthrough:
    • adjusted sizing to it's not spread out as far to the top and bottom of the screen
    • tried to mitigate the overlap on narrower screen sizes by lowering the size if the window height is high, but width lower (though this is more an issue of the tower not scaling down more in these cases, which needs to be fixed/adjusted in the webgl)
    • bring down the font-size for the main ruler mark number on lower resolutions
    • format numbers
  • fixed some typos and lints

Motivation and Context

How Has This Been Tested?

  • locally:
image image image

@shanimal08 shanimal08 marked this pull request as ready for review October 9, 2024 09:08
@stringhandler stringhandler merged commit 6b09f21 into tari-project:main Oct 9, 2024
9 checks passed
@shanimal08 shanimal08 deleted the shanimal/fix-fonts branch October 9, 2024 09:34
@Anziskavds
Copy link

Tested successfully on Testnet 0.5.17 on MacBook Air 13 inch M1 2020 on Sonoma 14.5.

@Tas4tari
Copy link

Tested on Windows, was unnaabkle to Test the Show History
I'm still seeeing the double black line by block height on Windows 11

Screenshot (40)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slight tweak needed for gem earning animations
4 participants