Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firewall): handle firewall rules on windows #712

Merged
merged 18 commits into from
Nov 22, 2024

Conversation

mmrrnn
Copy link
Collaborator

@mmrrnn mmrrnn commented Oct 3, 2024

No description provided.

@mmrrnn mmrrnn marked this pull request as draft October 9, 2024 10:40
@mmrrnn
Copy link
Collaborator Author

mmrrnn commented Oct 9, 2024

There is an issue with setup wizard. Tari Universe is not auto-running after installation

@mmrrnn mmrrnn force-pushed the handle_firewall_rules_on_windows branch from 5c0d159 to e00eeff Compare October 9, 2024 10:41
@mmrrnn mmrrnn force-pushed the handle_firewall_rules_on_windows branch from a10eb30 to 2081505 Compare October 9, 2024 10:47
@mmrrnn mmrrnn mentioned this pull request Oct 24, 2024
Closed
@brianp
Copy link
Collaborator

brianp commented Oct 25, 2024

Holding off on this PR until next week.

@brianp brianp added the on hold Issue is being held for progress later label Oct 25, 2024
@mmrrnn
Copy link
Collaborator Author

mmrrnn commented Oct 28, 2024

Since we have our custom installer: #897

We can handle setting windows firewalls there and fix the issue with auto-start

@mmrrnn mmrrnn marked this pull request as ready for review November 7, 2024 09:05
Copy link
Collaborator

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't build on windows:

   Compiling tari-universe v0.6.4 (C:\Users\brian\Projects\universe\src-tauri)
error[E0432]: unresolved import `crate::utils::setup_utils::windows_firewall`
  --> src\gpu_miner_adapter.rs:16:32
   |
16 | use crate::utils::setup_utils::windows_firewall::add_firewall_rule;
   |                                ^^^^^^^^^^^^^^^^ could not find `windows_firewall` in `setup_utils`

error[E0432]: unresolved import `crate::utils::setup_utils::windows_firewall`
  --> src\node_adapter.rs:24:32
   |
24 | use crate::utils::setup_utils::windows_firewall::add_firewall_rule;
   |                                ^^^^^^^^^^^^^^^^ could not find `windows_firewall` in `setup_utils`

error[E0432]: unresolved import `crate::utils::setup_utils::windows_firewall`
  --> src\p2pool_adapter.rs:19:32
   |
19 | use crate::utils::setup_utils::windows_firewall::add_firewall_rule;
   |                                ^^^^^^^^^^^^^^^^ could not find `windows_firewall` in `setup_utils`

error[E0432]: unresolved import `crate::utils::setup_utils::windows_firewall`
  --> src\wallet_adapter.rs:22:32
   |
22 | use crate::utils::setup_utils::windows_firewall::add_firewall_rule;
   |                                ^^^^^^^^^^^^^^^^ could not find `windows_firewall` in `setup_utils`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `tari-universe` (bin "tari-universe") due to 4 previous errors

@brianp brianp merged commit 49beeec into tari-project:main Nov 22, 2024
9 checks passed
@brianp
Copy link
Collaborator

brianp commented Nov 22, 2024

This was tested on Windows 11, and 10. It seemed to be a bit intermittent, but it generally made things better. We're merging for now, with the understanding that once tauri v2 is in, we'll be able to continue to improve this issue, easier than we can now. So it's a small win with a bright future.

@Tas4tari
Copy link

Tested on Windows 11. i did a fresh install of 0.7.7 and did not receive a pop up on Windows asking for permission to run xmrig, mmproxy, sha_p2pool etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Issue is being held for progress later p-controversial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants