chore(log): logging improvements #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mmrrnn
commented
Sep 30, 2024
mmrrnn
commented
- Unify dirs structure - every binary(except xmrig) has config and log dir. All are nested at the same level.
- limit logs size to 2mb, use level warn
- Create log4rs config on every run and save it to the configs dir for each binary.
PikoroNamekiano
approved these changes
Oct 8, 2024
mmrrnn
force-pushed
the
logging_improvements
branch
from
c326926 to
b7b2519
Compare
brianp
requested changes
Oct 9, 2024
Comment on lines
-1667
to
+2076
| tari_common::initialize_logging( | ||
| let contents = setup_logging( | ||
| &app.path_resolver() | ||
| .app_config_dir() | ||
| .expect("Could not get config dir") | ||
| .join("logs") | ||
| .join("universe") | ||
| .join("configs") | ||
| .join("log4rs_config_universe.yml"), | ||
| &app.path_resolver() | ||
| .app_log_dir() | ||
| .expect("Could not get log dir"), | ||
| include_str!("../log4rs_sample.yml"), | ||
| include_str!("../log4rs/universe_sample.yml"), | ||
| ) | ||
| .expect("Could not set up logging"); | ||
| let config: RawConfig = serde_yaml::from_str(&contents) | ||
| .expect("Could not parse the contents of the log file as yaml"); | ||
| log4rs::init_raw_config(config).expect("Could not initialize logging"); |
There was a problem hiding this comment.
What exactly is happening differently that tari_common::initialize_logging wasn't doing that required duplicating this functionality?
|
Check out current logs structure. All binaries` logs are placed randomly, without specific structure |
|
I understand what the goal of the PR is. But the original code wasn't simply dropping files in random places. It was configurable. So why did we have to duplicate the function. What changed in the function fundamentally that didn't work before? If you had corrected the paths as this pr does, could we continue to use the original |
|
default tari logs path hardcode |
mmrrnn
force-pushed
the
logging_improvements
branch
from
2ea10e1 to
27378f7
Compare
|
Tested successfully on Windows 11, app version 0.6.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.